Refactor to React Query hydration pattern and fix favorites bug#64
Merged
Conversation
The favorite toggle on listing detail pages was broken because the backend retrieve view did not pass request context to the serializer, so is_favorited always returned false. Additionally, the frontend stored favorite state in a separate query with staleTime: Infinity that could never self-correct. This adopts React Query's hydration pattern (prefetchQuery + dehydrate + HydrationBoundary) for grid and detail pages, replacing the initialData-from-props approach. The favorite toggle now uses optimistic updates on the listing cache entry itself. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retrieveview was not passingcontext={"request": request}to the serializer, sois_favoritedalways returnedfalse. The frontend's separate favorite query withstaleTime: Infinitycould never self-correct.initialData-from-props withprefetchQuery/setQueryData+dehydrate+HydrationBoundaryfor both grid and detail pages. React Query now has full ownership of the data lifecycle.Test plan
pnpm lintandtsc --noEmitpass🤖 Generated with Claude Code